For an RFC, whether consensus is reached is not clear
xxchan opened this issue · 0 comments
Raise this issue since I saw @neverchanje 's comment here: risingwavelabs/risingwave#7211 (comment)
I think we should settle (get the PR merged) the RFC before implementing it. I'm not sure if anyone has agreed on the final design
IIRC, we had only reached the consensus that ...
Since we merge RFC after finishing implementation, the status for open RFCs are indeed not very clear.
Although actually there's a label required in the process:
- Team members will comment on your RFC PR and hold an RFC meeting about that.
- If your RFC is accepted, the team member will add a label
status/accepted.- Create a tracking issue and start your implementation.
But it's not widely adopted.
I guess the reason not to merge the RFC PR is that the design might be subject to change and we can keep discussion open. But we should be more explicit about the progress.
A formal process like voting might be unnecessary, but just before implementation, leave a concluding comment sumarizing the consensus reached would be very helpful to avoid confusion and conflicts.