Requests?
Closed this issue · 5 comments
@khipkin https://github.com/rit-csc/CSCWebsite/blob/github_api/csc_new/pages/views.py#L54 Why is the requests package necessary when both json and urllib are python builtins?
@RaineForest, I don't know. This is my first vaguely-successful attempt to use an API. Are you saying the same thing can be done with python built-in libraries?
Yes
I don't think this should be filed as an issue per se, because it seems to be commentary on code that hasn't even been merged into live yet. Not saying that this one should be removed but for future occurrences like this, that's my opinion. Agree/disagree?
Better yet, is there a way to limit the scope of a filed issue to a specific branch?
@chrissprague @RaineForest Even if it isn't on the live site or the primary branch, it's still an "issue" with the codebase that Dakota felt should be addressed. Now that I know everything mentioned above, I also agree that it is an issue. I will fix it ASAP.