ritz078/rollup-plugin-filesize

Why output gzipped size when I am not writing a gzip?

Closed this issue · 7 comments

binarykitchen commented

With my current rollup config I am not writing a gzip to the destination folder. But your plugin still displays gzip stats. Not necessary and confusing in my opinion. Can the plugin be smarter?

ritz078 commented

It can be made optional.

binarykitchen commented

yeah please, that would be cool

ritz078 commented

try v1.4.1 and set showGzippedSize: false in options.

binarykitchen commented

yeah @ritz078 it works, but the implementation could be better: there is no need to calculate gzipSize unnecessarily when it's not shown, see

rollup-plugin-filesize/src/index.js

Line 34 in 2631329

let gzipSize = fileSize(gzip.sync(code), opts.format);

add a conditional there ...

... plus the file is too wide, better break it at column 80 or so.

ritz078 commented

Ya sure. I will do those when I have a bit of time. I just made a quick release for now so that it solves your problem.

ritz078 commented

Done in 1.4.2

binarykitchen commented