rixwew/pytorch-fm

why "self.fc = torch.nn.Embedding..." in class FeaturesLinear

zanshuxun opened this issue · 1 comments

zanshuxun commented

self.fc = torch.nn.Embedding(sum(field_dims)+1, output_dim)
https://github.com/rixwew/pytorch-fm/blob/master/torchfm/layer.py#L10

I'm wondering whether this is a writing misktake

rixwew commented

That is a patch for MovieLens dataset #6
To avoid confusion, I removed +1 at embedding. Instead, I changed MovieLens field dims.
782d959

  • 👍1