rizerphe/obsidian-companion

The accept short cut (Tab) dont work if the vim keys are enabled

ecruzolivera opened this issue · 5 comments

ecruzolivera commented

Hi all, thanks for building this plugin, is very cool.

Any chance that the accept command key can be customizable, I use Obsidian in vim mode and this plugin doesn't work with that.

ecruzolivera commented

dont work on lists but it works on paragraphs

DimitrisMilonopoulos commented

you can use ctrl + space for lists

  • 👍1
rizerphe commented

I'm working on it, thank you.

rizerphe commented

Thanks again! I have added the ability to create your own accept shortcut by either specifying a new CodeMirror one or adding a keybind to the "accept completion" command (Settings > Hotkeys). I'm not closing this issue yet though as there is more work to do - the behavior of the tab key is modified even if you disable the CodeMirror keybind, and I haven't tested the behaviour of CodeMirror with vim mode at all.

rizerphe commented

Now, the plugin should entirely disable the keymap modifications if the shortcut is disabled in the settings, and it shouldn't suggest completions at all in normal mode with vim keybindings while working as usual in insert mode. If you have any further feedback, don't hesitate to let me know!

  • 👍1