rjanot/YuccaPrerenderBundle

Support Symfony 4

Opened this issue · 3 comments

vharish commented

Hi,

It's clear from the composer file that the supported version of Symfony is 3.3. I would like to know if there are any plans to update the library to support Symfony 4.

Thanks.

rjanot commented

Hi, thanks for the question.

Honnestly, it's not in the pipe on my side.
But If you upgrade requirements, please, do a PR, I will be really happy to merge it.

Rémi

vharish commented

@rjanot Thanks for the reply. I'll see what I can do.

vharish commented

@rjanot Simply updating the version constraint to allow symfony framework version 4.0 has worked. However, I haven't run any test cases and I can't say for sure that no other changes are required, although I believe everything works fine as it is.

For our use case though, the above mentioned change has worked. I've forked the repo and made the changes. I am not going to create a PR for the reasons stated above.

Thanks,
Harish