rjbs/Email-Stuffer

Is this documentation typo?

Closed this issue · 7 comments

tomascohen commented

It seems so.

rjbs commented

Fixed, thanks!

KES777 commented

@rjbs Hi, thank you for fix. I have review my report and your fix and it looks still inconsistent:
image

I think it should be called as $attribute => $value, because at that position we put just one, then can repeat pair. And this fix should applied to all two sections: html_body, text_body. attach and attach_file already seems correct.

rjbs commented

Thanks for this reply. In my previous patch, I just sort of blindly did what I thought you asked. I will, this time, carefully review the documentation myself and make sure I think I do something sensible.

rjbs commented

I believe this is better in v0.020, thank you.

  • 🚀1
KES777 commented

Actually my first report was terrible.

Now your changes makes documentation really nice. There is no funny chars at the menu
image

and there is no bash syntax for optional arguments: =method text_body $body [, $attributes => $value, ... ]

But I have one more request:

-$stuffer->header($header_name = $value)
+$stuffer->header($header_name => $value)
rjbs commented

Thanks, I fixed that, but I don't plan to cut a new release just for that right now!

  • 👍1