rladies/meetupr

get_events() throws an error when no events found for a query

missaugustina opened this issue · 6 comments

missaugustina commented

Via Athanasia

Hi folks! I’m playing around with the meetupr package we have on github.
I was wondering whether theget_events function should throw an error when no events are found for a query? Is it really an error if there are no upcoming events? Should it not rather be a warning?

I am looking to see if our code is doing this or if its something from the Meetup API.

ledell commented

@missaugustina No, it should definitely not throw an error. Are they using the latest version of the package? If so, can you (or they) post a reproducible example? Thanks! :-)

missaugustina commented

Yes @ledell i'm pushing an update to the unit test where I repro'ed

  • 👍1
missaugustina commented

I need the test to catch the httr::stop(), figuring how to do that with testthat rn.

Screen Shot 2019-09-04 at 2 03 38 PM

missaugustina commented

PR up but need coverage for other methods to make sure they don't barf.

  • get_boards.R
  • get_event_attendees.R
  • get_event_comments.R
  • get_event_rsvps.R
  • get_members.R
  • 👍1
  • 🚀1
missaugustina commented

I have to get Meetup auth set up on my end to do a full end-to-end test. If someone who has it set up could test this branch in the meantime I would be most pleased :)

  • 👍1