rladies/praise

Request to move "posh" from praise

Lextuga007 opened this issue · 2 comments

Lextuga007 commented

Would it be possible to remove the word "posh" from the praise file https://github.com/rladies/praise/blob/ab66fe2b6080f0a2d55c4b3c395529a8271a4034/R/adjective.R as this isn't necessarily praise in British English? I checked this on Twitter as a poll as I wasn't sure if it was just me but it got quite a few votes saying no, it isn't a compliment. Although it can be used as praise as in, "don't you look posh!" it's never used in the constructed praise of "you are posh!".

Thanks for a great package - we are using this in our internal package and it's lovely to see who gets the next random praise (which is where I saw this phrase)!

gaborcsardi commented

Do you want to submit a PR? Thanks!

  • 👍1
Lextuga007 commented

I'd love to 👍🏻 Thanks!