rlespinasse/github-slug-action

GITHUB_REF_SLUG on pull request differs between v2.x and v3.x

rlespinasse opened this issue · 3 comments

rlespinasse commented

On pull_request event, the GITHUB_REF value is refs/pull/<pr number>-merge
So,

  • on v2.x, the value is <pr number>-merge
  • on v3.x, the value is refs-pull-<pr number>-merge

During the migration from docker-based action (v2.x) to javascript-based action (v3.x), the bug have been introduce.

rlespinasse commented

First try to fix this bug have been done with 78985f8
But an use-case of GITHUB_REF_SLUG now fail due to this fix (see #55).

This migration bug become a feature and so the bugfix 78985f8 have be reverted by #56

rlespinasse commented

Finally, the associated bugfix will be keep.

rlespinasse commented

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀