Mock assert_called() fails on py35 only
Closed this issue · 5 comments
rm-hull commented
See FIXME's in tests/test_neopixel.py
thijstriemstra commented
Is this visible on travis?
rm-hull commented
Can't find the failed builds on the led_matrix repo, but heres a similar one on luma.oled: https://travis-ci.org/rm-hull/luma.oled/builds/196357642
thijstriemstra commented
assert_called isn't documented on https://docs.python.org/3.5/library/unittest.mock.html. assert_called_with is and I think this should be used instead. Making a PR now.
thijstriemstra commented
There's actually a called boolean that looks better: https://docs.python.org/3.5/library/unittest.mock.html#unittest.mock.Mock.called
thijstriemstra commented
See rm-hull/luma.oled#132 for luma.oled, working on luma.led_matrix PR now.