rmariuzzo/Laravel-JS-Localization

Laravel 5.4

gerciljunio opened this issue · 5 comments

gerciljunio commented

Hello, do you have any plans to adapt to laravel 5.4? I was updating my system and found an error in LaravelJsLocalizationServiceProvider.php on line 67, I believe that is why the share method was removed in the latest version of laravel. Thanks!

rmariuzzo commented

Hey @gerciljunio! Yes, there's a pending PR for 5.4 support, I will do my best to merge today or by tomorrow.

  • 👍1
  • 🎉1
antonkomarev commented

@joelcuevas this planned for future releases. Feel free to add PR for it! :}

rmariuzzo commented

@gerciljunio I have merged this: #83 which add Laravel 5.4 support. I'm now writing proper tests that match Laravel 5.4. If it all works, I'm releasing it today.

rmariuzzo commented

Quick update: I'm tracking the addition of Laravel 5.4 tests here: #86