mp3 download of books on latest version doesnt have metadata
Closed this issue · 5 comments
Describe the bug
mp3 download of books on latest version does not have the metadata (cover,name of book name of author etc...)
To Reproduce
Steps to reproduce the behavior: use libation mp3 download setting and download origins by dan brown normally!
double click on mp3 notice lack of cover art and name in groove music on windows 11
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Expected behavior
i expect to see the proper metadata in groove music and itunes
Screenshots
If applicable, add screenshots to help explain your problem.
Platform windows 11
Log Files
Attach your Libation log file here. Logs are typically in your [user]\Libation folder. (For example, on windows: C:\my_username\Libation) Also within Libation, on the first tab in Settings you can click the button 'Open log folder'. If your user folder contains the file "LibationCrash.log", attach that also.
@supertails12 Sorry about that. Fixed in the latest release.
@rmcrackan I tested 4-part version names with auto-update and they work fine. (Tested using v12.0.1). I think it makes sense for minor bugfix releases like this, but let me know if you disagree.
Fixed thank you!
Thanks for the quick fix. Yeah, a .2 is fine as long as you tested it. I've never used the 4th part for Libation before. I don't think it used to work before one of your recent updates. If it works now -- sweet, thanks.
If it works now -- sweet, thanks.
It does work for the auto update, but I did notice that the verson isn't displayed properly everywhere inside Libation. The only place this actually makes a difference is in the "Last Downloaded" column, where it will only display 3 version parts. I've fixed it in my repo and will do a PR later this week. It's not a critical function.
Sounds good. Maybe make a variation on ToString for us to use in the GUI where it doesn't print trailing .0 entries. This way it will match the version on the download page. Off the top of my head:
static class VersionExtension
enum VersionFormat { All, Minimal }
string ToString(this version, VersionFormat format) => format switch
{
VersionFormat.Minimal => minimize(version),
VersionFormat.All => version?.ToString()
_ => throw whatever
}
private string minimize(Version version)
{
if (version is null) return "";
var verString = version.ToString();
while (verString.EndsWith(".0"))
verString = verString.Remove(verString.Length - 2);
return verString;
}