rmehri01/onenord.nvim

Inconsistent colors from one version to another

Closed this issue · 4 comments

Hello,

I've seen recent changes on that 71bdcdf commit that put wrong colors on some part of code:

before

Screenshot 2023-02-13 at 12 41 35

after

Screenshot 2023-02-13 at 12 42 06

How can I fix this to have the same colors than before?

thanks a lot !

Hi, sorry about that, I was trying to make it more consistent with treesitter for example when namespacing a function. In Rust the base syntax Include is also used for both the imports and uses vs treesitter using @namespace and @struct.

Base syntax before change:

image

Base syntax after change:

image

Treesitter highlight:

image

You can always change custom highlights doing the following:

      local colors = require("onenord.colors").load()
      require("onenord").setup({
        custom_highlights = {
          Include = { fg = colors.blue },
        },
      })

This one just changes the namespaces but feel free to customize anything else to your liking 😄

Okay sorry for the delay, I've decided to revert these changes since I guess it's okay that the two aren't perfectly consistent and there are other ways to fix the semantic token highlighting.

This issue seems to need to be re-open as I see some new issues on some code highlight cc @rmehri01

Hi, did you upgrade to neovim 0.9 recently? If so, this is probably due to LSP semantic tokens. You can check it out under :h lsp-semantic-highlight or disable it using something like client.server_capabilities.semanticTokensProvider = nil in your on_attach.