rmehri01/onenord.nvim

Can overrdie background

Closed this issue · 8 comments

I'm not sure what I'm doing wrong:
image
It should make the background black right?

Hi, have you updated onenord recently because I think I fixed a few bugs related to configuration.

Ok, by bad. I had two themes : nightfox and onenord - both are using setup() functions for customization.
Disabling nigthfox helped to load onenord.setup() with updated background color .
I guess there is no way to customize highlights of onenord unless it is loaded as 'main/startup' colorsheme.

Ah I see, yeah I recently switched to a config structure similar to nightfox since it seems to work better for me. I could try to find a way to get them to work together if you think that would be helpful?

Well I think if maybe you could use ColorScheme autocmd
` autocmd ColorScheme * call xxxx
So that when users changes colorscheme, onenord will read updated setup() ? Not sure if this can fix the issue...

I just pushed a commit, can you try out your old setup with nightfox? It seems to work for me.

I think that could work, what I did was essentially just make a new field for config.options like nightfox does and then mutate that with setup so that it can still be used when switching themes.

Thanks it works now. Great theme btw.

Thanks it works now. Great theme btw.

Awesome, thanks for testing it out! I'm glad you like it 😄