ComposableResources and SlotResources are unused storages, should be deleted
bmacer opened this issue · 1 comments
bmacer commented
Quite sure all of the storages go directly to Resources
, regardless of type, so it should be safe to delete these two storages
rmrk-substrate/pallets/rmrk-core/src/lib.rs
Lines 160 to 186 in 3034ae3
bmacer commented
Indeed we do use these storages. ComposableResource
is populated during add_composable_resource
and is used to check for the existence of a base on an NFT during equip
in the equip pallet. Similarly, SlotResource
is used for ensuring the existence of a slot on a particular NFT's particular resource when doing an equip
in the rmrk-equip pallet.
Proposing changing these names to be more clear
ComposableResources
-> EquippableBases
SlotResources
-> EquippableSlots