Remove Locks when selling or unlisting an NFT
HashWarlock opened this issue · 2 comments
Description
Currently Locks are set to false instead of being removed whenever they are released in unlist_nft and accept_offer. We should remove the Lock to reduce space.
@HashWarlock Just to let you know so that you don't work on something that has already been done, a small part of this issue has been fixed here.
I assume that the PR for this issue would also make a migration to remove unnecessary storage items.
And I assume that a test could be written for this. So do you want me to revert the lines I have changed inside my PR regarding this issue so that there would be a separate PR for this?
@HashWarlock Just to let you know so that you don't work on something that has already been done, a small part of this issue has been fixed here. I assume that the PR for this issue would also make a migration to remove unnecessary storage items. And I assume that a test could be written for this. So do you want me to revert the lines I have changed inside my PR regarding this issue so that there would be a separate PR for this?
Nvm I just read your PR and that is the fix I need. Thanks for adding that.