rmsramos/activitylog

No need to formatDateValues

ccxop opened this issue · 5 comments

Package Version

v1.0.7

Laravel Version

v11.27.2

PHP Version

php 8.2

Problem description

\Rmsramos\Activitylog\Actions\Concerns\ActionContent::formatDateValues

if column is a decimal value:

$value = Carbon::parse('1.00')->format('d/m/Y H:i:s');

result is 01/01/1970 00:00:01

I think it is no need to format any value, because the log looks at the original value is make sense###

Expected behavior

no need to format any value

Steps to reproduce

\Rmsramos\Activitylog\Actions\Concerns\ActionContent::formatDateValues

if column is a decimal value:

$value = Carbon::parse('1.00')->format('d/m/Y H:i:s');

result is 01/01/1970 00:00:01

Reproduction repository (issue will be closed if this is not valid)

https://github.com/rmsramos/activitylog

Relevant log output

No response

Fix proposed with PR #61

Wat can we do to make sure this fix is merged back?
I have the same issues.

At the latest tomorrow I will release a new version

At the latest tomorrow I will release a new version

Hi @rmsramos, any news here? Ty

There are more values incorrectly casted to dates....i have for example a string employee_number: "2222" which also shows up as a date in the view, while it is stored correctly in the log as "2222"