New object class names
rnelsonchem opened this issue · 2 comments
Looking for feedback on new object class names. Here's the proposed nomenclature:
- AcidAq -- Used to define aqueous species that have known Ka/pKa values
- IonAq -- Used to define an aqueous ion. These are assumed to not participate in any aqueous equilibria, but their charge will affect the overall charge balance
- SystemAirEquilibrated -- A subclass of System to equilibrate the solution with atmospheric CO2. See PR-6
- AcidGas -- Used to define a gas in equilibrium with the solution. In solution, the gas participates in acid/base equilibria. I.e. NH3 and CO2/H2CO3. See PR-7
I very much like the new nomenclature for AcidAq and IonAq.
SystemAirEquilibrated seems a decent choice, although I anticipate that this class may become obsolete prematurely, with the arrival of the AcidGas type of object.
I wonder if AcidGasEq would perhaps be a clearer name, since this class models an acid in solution in equilibrium with a gas-phase reservoir of the acid species.
Curious for your thoughts on renaming the class for acids and bases which do not fully dissociate "WeakAq" and acids and bases which fully dissociate "StrongAq." This seems to be more consistent with literature which I've seen, and eliminates the confusion of using a class called "Acid" or "AcidAq" to describe a "weak" base.
May also be useful to add an "Ion" or "NeutralIon" class for salts which have no impact on pH.