ro31337/libretaxi

Add Persian translation json file

ro31337 opened this issue · 2 comments

ro31337 commented

Add Persian language translation. Original author: @MR5857 in Telegram. Here is the translation itself https://gist.github.com/ro31337/ed182538dbebd62f9f99bb3315738e83

Unfortunately, I have no skills with editing right-to-left text, and I don't know how GitHub and Telegram handles it (I assume it handles OK).

So in this story do the following:

  • Check translation by comparing keys to English: https://github.com/ro31337/libretaxi/blob/master/locales/en.json
  • Pay attention to passenger-contact-new-number.message and passenger-contact-driver-price.message - there is information that translation can be incorrect because GitHub doesn't support (?) right-to-left text (?).
  • Make sure strings containing %s, {{something}} spelled correctly and there are no unicode characters between them (otherwise string interpolation will fail).
  • Make sure all icons are in place. For example, when I type "🚗 ماشین" into google translate, I get the following:

image

It seems right, in Persian icon is at the beginning (at the end visually). However, in json file it's at the end (at the beginning visually).

In Telegram it also seems right (when you paste "🚗 ماشین" without quotes, you get exactly what is expected):

image

The translation above can be technically correct, just attention from someone familiar with Git and Persian language is required.

So In this story:

  • Do all the checks written above
  • Add Persian translation file and create PR (you can create PR to the master branch, it's OK for this story)
  • In PR message verbosely explain what has been done, give as much information as it is possible.

This issue is high priority one and Persian-speaking community is looking forward to use the bot. Please help the world to be a better place by working on this issue.

ro31337 commented

Not yet, on the way. However, if you feel enthusiastic, consider translating index.html to Persian here: ro31337/libretaxi-www#17