roach-php/core

Parameter type requirements

ZhangChengLin opened this issue · 1 comments

ZhangChengLin commented

core/src/Spider/BasicSpider.php

Line 62 in 450ed50

public int $requestDelay = 1;

The $requestDelay attribute is expected to support expressions, and the target needs to be a specified range of random values ​​(including non-integer numbers).

core/src/Scheduling/RequestSchedulerInterface.php

Line 40 in 653347a

public function setDelay(int $delay): self;

The parameter type of setDelay is expected to support non-integer formats.

ZhangChengLin commented

By the way, why is the default concurrency here so high?

core/src/Core/Run.php

Line 41 in 653347a

public int $concurrency = 25,