robb0wen/synthwave-vscode

after I update vscode-insiders error ocurried

Opened this issue · 5 comments

VanderSP commented

YESSSSSSSSSSSSSSSS also just happened now... was 1.94 update.... how i will code now! i always needed to reenable synthwave, in admin mode... then reopen... etc... but was worth! :D

PLEASE WE WANT FIX!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

vinayakkulkarni commented 
024-09-16 02:28:08.674 [error] TypeError: Cannot read properties of undefined (reading 'filename')
    at /Users/vinayak/.vscode-insiders/extensions/robbowen.synthwave-vscode-0.1.15/src/extension.js:27:44

Seems the VSCode insiders update introduced a bug on this line –> https://github.com/robb0wen/synthwave-vscode/blob/master/src/extension.js#L27

After much more digging, found this – https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_93.md#impact-of-ecmascript-module-esm-loading-of-vs-code

vinayakkulkarni commented

Found a possible solution / hack:

update your local extension.js with this:

      const isWin = /^win/.test(process.platform);
      const appDir = `${path.dirname(vscode.env.appRoot)}/app/out`;
      const base = appDir + (isWin ? "\\vs\\code" : "/vs/code");
      const electronBase = isVSCodeBelowVersion("1.70.0")
        ? "electron-browser"
        : "electron-sandbox";
      const htmlFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\workbench.esm.html"
          : "/" + electronBase + "/workbench/workbench.esm.html");
      const templateFile =
        base +
        (isWin
          ? "\\" + electronBase + "\\workbench\\neondreams.js"
          : "/" + electronBase + "/workbench/neondreams.js");

Basically you have to patch these lines – https://github.com/robb0wen/synthwave-vscode/blob/master/src/extension.js#L26-L41

Might send a PR for the fix.

VanderSP commented

Hey THANKS! Back working in NEON!!!!!!!!!

Also i would like to ask you all, you all use it like me?

i open vscode as admin... apply the synthwave command with ctrl shift p and selecting it

then restart.... then restart again without admin

then finally hitting to dont say alert anymore....

EVERYTIME THAT I HIT UPDATE ON INSIDERS LOL

  • 👍1
GeorgiNiagulov commented

Yes this fix it's working thanks :) I believe https://github.com/robb0wen will see and accept pull request!

  • 👍1