robbestad/react-stickydiv

Supporting current version of react

Opened this issue · 7 comments

markthethomas commented

Love this lightweight component; are there any plans to allow support for react 0.13.x?

robbestad commented

Thanks! :) What issues do you have? I thought it already worked flawlessly with React 0.13 ;)

markthethomas commented

Getting a peer depency issue thrown from npm; looks like its a bad requirement in package.json

peerDependencies": { "react": ">=0.12 <0.13" }

robbestad commented

Aha, silly me:) I've changed it to

 peerDependencies": { "react": ">=0.12" }
robbestad commented

Looking at the code, I see that I'm using getDOMNode. I'll create a version that uses findDOMNode if that's available and getDOMNode is not (for 0.13 compatibility)

markthethomas commented

Happy to submit a PR with the patches for everything :)

Mark

@markthethomas everywhere

On Jun 3, 2015, at 3:24 AM, Sven Anders Robbestad notifications@github.com wrote:

Looking at the code, I see that I'm using getDOMNode. I'll create a version that uses findDOMNode if that's available and getDOMNode is not (for 0.13 compatibility)

—
Reply to this email directly or view it on GitHub.

robbestad commented

👍

alexeyraspopov commented

@svenanders how about using ">=0.12 || 0.14.0-rc1" in range? Did you already test stickydiv with 0.14rc?