robert/gameboy-doctor

cpu_instrs 7: ROM used to generate log file doesn't match version currently available

Closed this issue · 10 comments

yoursred commented

07-jr,jp,call,ret,rst.gb has 3C C9 00 00 00 00 00 00 repeated 6 times at offset 0000. The ROM used has 31 FE FF AF.

============== ERROR ==============

Mismatch in CPU state at line 254074:

MINE:	A:12 F:---- B:12 C:00 D:DE E:FB H:C6 L:3D SP:DF7C PC:0000 PCMEM:31,FE,FF,AF
YOURS:	A:12 F:---- B:12 C:00 D:DE E:FB H:C6 L:3D SP:DF7C PC:0000 PCMEM:3C,C9,00,00

Our values for PC are the same, but the memory at the location of PC is different. Perhaps you told me to check the wrong ROM type or number?
yoursred commented

I eventually got it to work by generating a new log file using a known-working emulator.
The issue also affects 02-interrupts.gb:

============== ERROR ==============

Mismatch in CPU state at line 151347:

MINE:	A:04 F:C--- B:01 C:00 D:C7 E:BA H:90 L:00 SP:9000 PC:0051 PCMEM:2E,0F,18,F3
YOURS:	A:04 F:C-NZ B:00 C:00 D:C7 E:BA H:90 L:00 SP:DFFB PC:0051 PCMEM:C9,00,00,00

Our values for PC are the same, but the memory at the location of PC is different. Perhaps you told me to check the wrong ROM type or number?
robert commented

🤔 interesting. Mind making a PR with your updated logfiles so I can take a look?

robert commented

Oh I wonder if I forgot to disable the boot ROM when running my emulator!

yoursred commented

I think so actually, the values do match at those offsets.

yoursred commented

Relevant PR: #8

yoursred commented

And another thing, I think the log file for 2 fails the test with "Timer doesn't work"

garado commented

PR #11 has new log file with boot rom disabled for cpu_instrs 2

elmarsan commented

Hey I'm having the same issue.

cpu_instrs 7

============== ERROR ==============

Mismatch in CPU state at line 254074:

MINE:	A:12 F:---- B:12 C:00 D:DE E:FB H:C6 L:3D SP:DF7C PC:0000 PCMEM:31,FE,FF,AF
YOURS:	A:12 F:---- B:12 C:00 D:DE E:FB H:C6 L:3D SP:DF7C PC:0000 PCMEM:3C,C9,00,00

Our values for PC are the same, but the memory at the location of PC is different. Perhaps you told me to check the wrong ROM type or number?
nguillaumin commented

Same for me too. The bootrom theory matches as it starts with 31 FE FF AF:

00000000  31 fe ff af 21 ff 9f 32  cb 7c 20 fb 21 26 ff 0e  |1...!..2.| .!&..|

Hopefully #8 can be merged soon?

robert commented

Thanks for the reminder, I'd forgotten about that PR. Merged.

  • 👍2