robl2e/ThisTimes

Project Feedback!

Opened this issue · 2 comments

codepathreview commented

👍 Great work! A few notes after checking out the code:

  • IMPORTANT: Please submit a GIF (mandatory) for future assignments.
  • Properly reused the single base method in search activity to fetch results for both initial load and the pagination
  • Properly used spinners/checkboxes (with populated values) to allow users to select filters
  • Good to see you used model objects to represent the filters to apply to the query
  • Great job implementing DialogFragment for filters.
  • Nice to see you added the search box to the Toolbar!
  • Nice job adding the share intent to the article detail view!
  • Nice to see you used the new betterpickers dialog library.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

robl2e commented

Thanks for the feedback! I had question regarding submitting a GIF. I thought if a video is provided a GIF is not needed?

Originally I tried using a GIF but I hit an error stating there is a duration limit of 20 seconds when creating. I couldn't show off all worked on features in the time frame, so switched to using a video.

So in the future should I still include a GIF that-- just shows a brief overview, while including a video to show off all the features?

codepathreview commented

Thanks for letting us know about the upload issues @robl2e .
Actually, video link should be fine. Just confirmed with the team.