robotdana/leftovers

calls does not recognize qualified constant name with document: true

such opened this issue · 3 comments

such commented

Here is a minimal repository that reproduces the issue: https://github.com/such/leftovers_test

with a yml document such as:

class_name:
  - Foo::Bar
  - Baz

and a dynamic config such as:

dynamic:
  - document: true
    path: test.yml
    calls:
      argument: class_name
      nested:
        argument: '*'

Foo::Bar is not marked as called
Baz is correctly marked as called

you’ll need to add split: "::" as it’s just doing string matching on the values:
e.g.

dynamic:
  - document: true
    path: test.yml
    calls:
      argument: class_name
      split: '::'
      nested:
        argument: '*'

thank you for the repo tho it’s really clear

such commented

Thank you! Makes sense now