$doc->isSame($this->sigNode) is always false

Question

$doc->isSame($this->sigNode) is always false

Closed this issue 9 years ago · 5 comments

GoogleCodeExporter commented 10 years ago

Fix validate references for documents like 
<signature><object>data</object></signature>

Original issue reported on code.google.com by luisalbertolg@gmail.com on 13 Apr 2013 at 7:51

Attachments:

xmlseclibs.php.patch

Answer 1 · 2015-03-31T18:20:32.000Z

Attached patch and test case

Original comment by luisalbertolg@gmail.com on 13 Apr 2013 at 8:07

Added labels: ****
Removed labels: ****

Attachments:

patch.diff

Answer 2 · 2015-03-31T18:20:33.000Z

Can you review this?

Original comment by lalag...@ibercheck.com on 19 Jun 2013 at 8:40

Added labels: ****
Removed labels: ****

Answer 3 · 2015-03-31T18:20:33.000Z

I need to dig into that patch more as it doesn't cover all the possible cases 
that can happen when that function is called. I am trying to dig up the reason 
why I had originally done that (there was a specific use case). Didn't want 
this to hold up the 1.3.1 release as its been way too long but will plan on 
doing another cleanup release hopefully  before end of month which would 
include a fix for this issue.

Original comment by cdatazon...@gmail.com on 19 Jun 2013 at 8:57

Added labels: ****
Removed labels: ****

Answer 4 · 2015-03-31T18:20:33.000Z

Ok, Thank you

Original comment by luisalbertolg@gmail.com on 19 Jun 2013 at 9:30

Added labels: ****
Removed labels: ****

Answer 5 · 2015-05-21T12:46:54.000Z

I used a different fix for this which has better performance than using XPath.