rocket-pool/rocketpool

Additional multi parameter for Prometheus is concat on one parameter

korentzari opened this issue · 0 comments

Hello Rocket Pool Developers,

I'm encountering an issue while trying to add two additional parameters to Prometheus (--storage.tsdb.retention.time=2y and --web.external-url=/prometheus2). The problem arises because Prometheus seems to interpret "--storage.tsdb.retention.time=2y --web.external-url=/prometheus2" as a single parameter, which prevents it from functioning correctly.

Temporary Solution:
As a workaround, I've added a parameter in the template. However, this solution is not ideal since it gets overwritten with each new version release.

Suggested Fix:
I would like to discuss a more permanent solution to this issue, possibly by modifying the way Rocket Pool handles Prometheus parameters to ensure they are recognized correctly.

Steps to Reproduce:

  1. Attempt to add --storage.tsdb.retention.time=2y --web.external-url=/prometheus2 to Prometheus extra parameter in the current Rocket Pool setup.
  2. Observe that Prometheus treats these two parameters as a single parameter.

Any assistance or guidance on resolving this issue would be greatly appreciated.

Thank you for your time and consideration.