TP-Link Omada-Controller Rock-On

Question

TP-Link Omada-Controller Rock-On

Closed this issue 2 years ago · 11 comments

janholtzhausen commented 2 years ago

Modified the unify rock-on to run mbentley/omada-controller

Answer 1 · 2022-06-19T19:36:07.000Z

@janholtzhausen Hello there.

So could you give some more context / explanation here. I'm assuming you are about to present a pull request?

Answer 2 · 2022-06-19T19:39:56.000Z

Hi, thats right, still figuring out the correct procedure :)

Answer 3 · 2022-06-19T19:54:03.000Z

I hope it's not too much of a mess..

Answer 4 · 2022-06-19T19:58:47.000Z

@janholtzhausen
Re:

I hope it's not too much of a mess..

I wouldn't worry about that. ;)

We do have the following doc entry that may help with procedure:
https://rockstor.com/docs/contribute/contribute_rockons.html

Answer 5 · 2022-06-19T20:01:49.000Z

There, I think I checked all the boxes.
The next one will be a cleaner commit, I promise.
There, now it's public.

Answer 6 · 2022-06-20T00:33:50.000Z

@janholtzhausen I can see the Rockon in your forked repo itself, however you would still need to initiate the Pull Request from that branch so it becomes visible over here.

As you do this, quick comment on the description, I think at this point we're stopping to support the armv7 version, as that's still 32-bit and focus on amd64 and arm64 only. So you can take that out before creating the Pull Request.

Answer 7 · 2022-07-28T21:59:37.000Z

Is there anything else I need to do?

Answer 8 · 2022-07-29T00:21:42.000Z

@janholtzhausen, I don't think so, someone just needs to review it. i will see whether I can do it in the next few days.

Answer 9 · 2022-08-17T02:45:23.000Z

There's a couple more services I can contribute, but I'm not sure there's any interest?

Answer 10 · 2022-08-18T02:29:19.000Z

@janholtzhausen I would imagine there will be some interest, if you want to list the areas you're thinking about. I have tried to test your Rockon, but apparently I am running into some issues. I've successfully installed it outside of Rockstor, but I seem to be having some issues with my testbed for Rockons that I haven't figured out yet (ran into issues when testing other rockon submissions). Once I can resolve those, I will retest again. The lack of progress on these has more to do with available capacity than lack of interest. So, again thanks for your submission on the TP controller, we'll get it in.

Answer 11 · 2022-09-25T23:16:56.000Z

@janholtzhausen, sorry for the delay. I got to install it finally. I left some comments directly in the pull request, if you want to take a look at those.