rodekruis/shelter-database

LF instead of CR+LF

Closed this issue · 9 comments

Hello @humanitariandata ,

Is there a reason to switch to CR+LF formating?
I think that it would be good to switch back to LF for all files, as @mjvanderveen did ( 128d0df ) .
It will be easier for me to follow the project.
If needed I can send a PR.

thanks,

Cédric

Hi @cedricbonhomme,

Yes, I perform this command on init_db.sh because otherwise it is formatted for windows and fails on unix/ubuntu with a /bin/sh^M error.

Are you running on windows?

I am using Debian, no Windows fo me.

I experienced the same problem when I wanted to run drop_db.sh. Then I realized that almost all files were in CR+LF mode. So I pushed a commit just to switch back to LF.

What command do you use? then I will execute it on the whole repository.

This command should do the trick: find . -type f -not -path ".git*" -print0 | xargs -0 dos2unix

Maybe someone is using a very old Windows and/or have autocrlf to true in the Git config.

@ar-ge @Krysia can you check your settings?

Hi, I'm using mac, I checked conf.cfg file, autocrlf setting is not listed.

I suspect that this c5aeb31 added all the CR.

@mjvanderveen I also just checked git config, don't have autocrlf. maybe something happened on your side?