Plugin not working in Sketch 72 version

Question

Plugin not working in Sketch 72 version

roberthuston66 opened this issue 4 years ago · 14 comments

roberthuston66 commented 4 years ago

Answer 1 · 2021-05-06T16:20:31.000Z

Just opened a pull request that fixes this issue

Answer 2 · 2021-05-06T17:45:08.000Z

Any chance someone can test this build?
https://www.dropbox.com/s/dl/sv8n0fpp6nfnesb/Rename-It-4.5.4.sketchplugin.zip

I no longer have the latest version of Sketch to test it.

Answer 3 · 2021-05-06T19:44:27.000Z

Just tried it in Sketch 72.0 – doesn't work for me. Thanks for being on it!
Found this, where they mentioned the usage of an unofficial class by some plug-ins. https://spectrum.chat/sketch/bug-reports/cant-find-variable-msapplicationmetadata~0b44ab46-59e5-4736-b10c-4ec6e083d949

Answer 4 · 2021-05-06T21:36:57.000Z

@prvg any chance you can post the console error?

Answer 5 · 2021-05-06T22:17:14.000Z

ReferenceError: Can't find variable: MSApplicationMetadata
    at . (/node_modules/sketch-module-google-analytics/index.js@/Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:1992:36)
    at __webpack_require__ (/Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:27:34)
    at . (/src/lib/TheUI.js@/Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:5215:107)
    at __webpack_require__ (/Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:27:34)
    at . (/src/commandFindReplace.js@/Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:4729:87)
    at __webpack_require__ (/Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:27:34)
    at /Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:91:37
    at __skpm_run (/Users/johndoe/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Rename-It-4.5.4.sketchplugin/Contents/Sketch/commandFindReplace.js:92:12)
    at __skpm_run[native code] (/)

no idea where. perhaps this helps?

Answer 6 · 2021-05-06T22:18:49.000Z

@prvg thanks! I will see if I can fix this.

Answer 7 · 2021-05-07T08:07:48.000Z

Again: this PR I opened yesterday fixes this issue #149

Answer 8 · 2021-05-07T08:09:21.000Z

Again: this PR I opened yesterday fixes this issue #149

I compiled from your PR and people are still having issues.

Answer 9 · 2021-05-07T08:19:11.000Z

Ah, sorry, I thought you had missed my comment 🙈

One thing you could try is make sure you clean your node_modules folder. I made some changes in package versions and that might explain the issues you're seeing.

Also: please email me at ale@sketch.com and I'll make sure you get a license for the current version (I can't imagine how frustrating it must be to work on this blindly 😬)

Answer 10 · 2021-05-07T09:02:19.000Z

@prvg Here is a new build: https://www.dropbox.com/s/sv8n0fpp6nfnesb/Rename-It-4.5.4.sketchplugin.zip?dl=1

@bomberstudios thanks for your help. I followed your instructions and recompiled the plugin. Hopefully, it works now. FYI, I sent you an email.

Answer 11 · 2021-05-07T09:05:37.000Z

@rodi01 it Works, thank you!

Answer 12 · 2021-05-07T09:06:59.000Z

Oh my God it's working ! Thank you so much !! I thought I was going nuts !

Answer 13 · 2021-05-07T09:07:51.000Z

Awesome! I'll publish the update now.

Answer 14 · 2021-05-07T22:19:32.000Z

Awesome, thank you so much! 🎉