rodlie/qtfm

Dangerous: Deleting Bookmark, deletes underlying directory

Closed this issue · 5 comments

imrn commented

It will be good to overhaul "Bookmark Management".

rodlie commented

Unable to replicate.

imrn commented

Details:
1- Create a folder
2- Create a bookmark for it
3- Go to bookmarks pane
4- Right click on the new bookmark.
5a- Selecting "Delete" brings up a dialog: "Warning: You are about to delete path"
Confirmation certainly DELETES the path. But invalid bookmark stays there.
Note that, user is only expecting to delete the "bookmark". That's why it is dangerous.
5b- Select "Move Trash". path itself is moved to trash. Invalid bookmark continues to
stay there.

imrn commented

There is no way I can really delete the "Bookmark" itself other than
opening the config file in text editor and deleting it manually.

rodlie commented

6.1.6 added tab completion, but it broke the context menu for bookmarks. 6.1.7/master fixes this.