roeniss/dhlottery-api

[credentials] multiple

seunggabi opened this issue · 4 comments

seunggabi commented

I suggest to use multiple account. (like aws credentials.)

# cat ~/.dhapi/credentials

[default]
id = asdf
pw = 1234

[sg]
id = qwer
pw = 5678

...

cmd

dhapi buy_lotto645 -q # default
dhapi buy_lotto645 -q --profile sg # sg

I will make pr. thx

roeniss commented

@seunggabi not important thing but you'd better remove the pr number in each commit message. As you can see above, your commits are distracting the issue page.

seunggabi commented

@seunggabi not important thing but you'd better remove the pr number in each commit message. As you can see above, your commits are distracting the issue page.

hmm.. I don't agree with you.
commit & pr connection is important.

I use this. https://gist.github.com/seunggabi/8fa40a3585d37519db5beab5f0563766

roeniss commented

You are connecting each commit to this Issue.
But in reality, the only matter is the code in the Pull Request. So the relation should be like this:

Issue A ㅡ Pull Request B ㅡ Branch C ㅡ Commit 3 (HEAD) ㅡ Commit 2 ㅡ Commit 1

When you mention the issue number in each commit message, you are actually breaking this relation and just connecting each commit to the issue right away. What does that mean? Does it have something to you? What would happen if you don't connect it? Is there any problem?

  • 👍1
seunggabi commented

늦게 봣네요.. merge 감사합니다.ㅎㅎ!

  • 👍1