rokucommunity/roku-deploy

Merge multi-argument functions into single `options` functions

Closed this issue · 1 comments

Several core functions in RokuDeploy take multiple arguments. We've been aligning on a single options object for many of our calls, so we should do another pass to ensure that mutli-argument functions are only multi-argument when absolutely necessary.

One example (not exclusive):
retrieveSignedPackage takes 2 arguments

public async retrieveSignedPackage(pkgPath: string, options: RetrieveSignedPackageOptions): Promise<string> {

but should be:

public async retrieveSignedPackage( options: RetrieveSignedPackageOptions): Promise<string> {

Fixed in #126