Margin issue when sticky header is disabled

Question

Margin issue when sticky header is disabled

gmclelland opened this issue 7 years ago · 6 comments

I noticed when view the Classic default theme and the sticky header is disabled, the page sits to close to the top bar.

When the sticky header is enabled, everything looks okay.

Answer 1 · 2017-10-25T22:18:38.000Z

I don't think that is actually the fault of AOS - I think it is the Module Settings Import / Export module, or maybe it's actually a PW core issue when adding a new fieldset before others on the module settings pages. If you disable AOS you'll see it's still a problem.

Answer 2 · 2017-10-25T22:29:08.000Z

Hmm.. On a different site with an older version of AOS it works properly.

I also tried unistalling the Module Settings Import / Export module, but it made no difference.

If you disable AOS you'll see it's still a problem.

Your right I do see this when the module is disabled.

Answer 3 · 2017-10-26T08:42:43.000Z

As I remember there was a fix for this in AOS, perhaps it got removed lately (by accident). I can confirm that it's like this by default.

Answer 4 · 2017-10-26T15:00:59.000Z

The site that works correctly is using AOS 1.5.7

Answer 5 · 2017-10-26T17:55:15.000Z

I guess I was wrong, I thought about the current fix that was present in case sticky header is enabled, so there was no fix for the non-sticky header case. I've fixed it, will update the module soon.

Answer 6 · 2017-10-26T18:30:49.000Z

Should be fixed in v163.