rollerderby/scoreboard

[BUG] V2025-Beta1 - Jammer Bounce logic in PBT not applied unless penalties applied to Jammers in P(L)T

bullseye555 opened this issue · 0 comments

Describe the bug
In the Penalty Box Timer screen, if 2 Jammers are marked as in the penalty box but the P(L)T hasn't yet entered a penalty, the Jammer Bounce logic doesn't get applied until BOTH skaters have had the penalties entered

To Reproduce
Steps to reproduce the behavior:

  1. Start a Jam
  2. From the PBT screen, tap on the Jammer number (left most of the 4 numbers)
  3. Tap Skater Sat Down
  4. Repeat 2 & 3 for other team jammer
  5. See that the bounce logic hasn't been applied
  6. In the P(L)T screen, enter a penalty for only ONE jammer
  7. Bounce logic still hasn't been applied
  8. Repeat 6 for the second jammer
  9. See that bounce logic has now been applied

Expected behavior
Bounce logic should be applied when it's marked as two Jammers in the box, regardless of if there is a penalty applied to the skaters or not - the P(L)Ts may not have had time to enter the penalty before their jammer sat in the box

Screenshots
image

Version: 2025-beta1

OS and version: Windows 11 Pro 23H2 - 22631.3737
Browser: Chrome
Version: 125.0.6422.142

Additional context
Ideally, the same bounce logic should be applied when simply tapping the "Jammer sat down" button (this would reflect in the "Remaining" countdown immediately altering as appropriate)
Below video shows 2 jammers being added by using their numbers with no bounce logic kicking in until the penalties are added, then again with 2 "Jammer Sat Down" taps

vlc-record-2024-06-17-16h08m02s-bandicam.2024-06-17.16-03-46-535.mp4-.mp4