romainl/Apprentice

Idea: link CurSearch to IncSearch

craigmac opened this issue · 5 comments

craigmac commented

I have trouble with current highlight figuring out which match I'm currently on, especially with a light cursor against a yellow background. I link CurSearch to IncSearch so that I can see exactly which one I'm currently on (with vim-cool). What do you think?

hi! link CurSearch Search Hard to see where cursor currently is:
Screen Shot 2022-05-02 at 10 54 53 AM

hi! link CurSearch IncSearch Now I can tell:
Screen Shot 2022-05-02 at 10 55 13 AM

Would linking CurSearch to IncSearch be a better default? I'm not too familiar with colorscheme stuff in Vim, so I don't know how setting this link would affect other things.

romainl commented

Hi. I agree with you, linking CurSearch to IncSearch makes the most sense and I actually brought it up in vim/vim#10133 but Bram's rebuttal also makes sense, especially given the current state of the feature, which seems unfinished.

I will probably make the link to IncSearch when I am sure the feature is ready.

  • 👍1
craigmac commented

Oh wow, I had no idea CurSearch was sort of new!

jmdevin commented

Would it be appropriate to revisit adding this idea now?

  • 👍1
jmdevin commented

@romainl , since this is closed I'm not sure it pinged you

romainl commented

I'm sorry it took so long but CurSearch now links to IncSearch on master.

  • 👍1