romanz/trezor-agent

KeepKey device defined as a Trezor device

Opened this issue · 2 comments

doolio commented

class KeepKey(trezor.Trezor):

Should this not be:

class KeepKey(interface.Device):
romanz commented

I used inheritance to re-use TREZOR agent implementation with KeepKey class.

doolio commented

Right. I guess I was curious to why this was done for the KeepKey and not the other hardware devices. Feel free to close this if you don't wish to change how this is implemented. If you would like to align the KeepKey device with the others for consistency then I could submit a PR for consideration.