romeerez/orchid-orm

non-async afterMigrate/afterRollback methods

Closed this issue · 1 comments

I'd like to have non-async afterMigrate/afterRollback, but the typings won't allow that:

beforeMigrate?(db: Db): Promise<void>;
afterMigrate?(db: Db): Promise<void>;
beforeRollback?(db: Db): Promise<void>;
afterRollback?(db: Db): Promise<void>;

I suppose it's safe to mark them as void | PromiseLike<void>.

Sure, a minor edit, I pushed an update with this.