rometools/rome

Support GraalVM native images

Closed this issue · 4 comments

artembilan commented

See more info here: spring-projects/spring-integration#3900.

It looks like reflect-config.json must contain entry for the com.rometools.rome.feed.module.DCModuleImpl class and all entries listed in the com/rometools/rome/rome.properties.
Including this rome.properties as an entry in the resource-config.json.

It might be also great to look into initialization some static properties at build time. Like SyndFeedImpl.CONVERTERS.

PatrickGotthard commented

Hi @artembilan,

I have no idea what is necessary to support GraalVM native images.
Please create a pull-request if you know what to do :)

Regards,
Patrick

  • 👍1
artembilan commented

OK. Will look into that in a couple weeks.

PatrickGotthard commented

Hi @artembilan,

thanks for your PR, I'll review it asap.

Some Offtopic: how do you maintain different (major) versions @ Spring (regarding to Git)?

I have no experience with that but I want to support Rome 2.x for a year while implementing massive backwards-incompatible changes in parallel for Version 3 (#637).

Regards,
Patrick

artembilan commented

Hey, @PatrickGotthard !

Well, our practice is like this:

  1. main (or master in your case) is the current version in development - major or minor. In my case it is currently 6.1.0.
  2. All the supported previous versions are in their respective branches, e.g. I have currently supported 5.5.x & 6.0.x.
  3. So, If have some fix to be back-ported to those versions I do cherry-pick or issue PR against that respective branch.
  4. If I'd like to play with, for example, 7.0 for the future, and have some major breaking changes over there, I create the branch like 7.0-WIP.
  5. From time to I rebase it to main to pick fixes up.

To make yourself more familiar with Git I'd recommend to take a look into this book: https://git-scm.com/book/en/v2