romm1of/flutter_third_lab

Review summary

Opened this issue · 3 comments

igor-leshkevych commented

Hi @romm1of @MaxBardyn @AndriyFrost .

There are a few issues with your branches/PRs:

  1. It's not clear what branch is the latest: you have master (empty), dev (some features but not all), and two feature branches. Ideally your main/dev should contain ALL latest changes, so I can clone it and run.
  2. Some of your feature PRs were merged into other PRs, and now it's not possible to identify the work done by person. Ideally, each of you should have a PR (or multiple PRs) with only his changes.

You need to fix your repository to get max score. By "fix the repository" I mean:

  1. There is a branch with latest changes
  2. There are PRs (no matter open or already merged), each PR contains only the code of single feature, developed by single person, so it can be easily reviewed.

Deadline: 27.10

romm1of commented

Hello, @igor-leshkevych ! Thanks for reviewing, as for issues:

  1. It was designed to do so. So that you could see all the code being inserted to master branch.
  2. I guess you may track it by commits.

Anyways, if that's what you ask, we'll get it done in that way.

igor-leshkevych commented

@romm1of thanks for the fix. I managed to review. App is OK, but for me it throws a bunch of errors when I try to select some group on "New Group" screen.

Code is nice, I would only suggest to follow Flutter conventions regarding file naming and use widget_with_underscores.dart instead of PascalCase.dart

You didn't do any code reviews in your team though, so your score will, unfortunately, be slightly reduced

romm1of commented

@igor-leshkevych thanks. We'll try to follow the conventions from now on