Remove dep on `Formatting.jl`?

Question

Remove dep on `Formatting.jl`?

haberdashPI opened this issue a year ago · 9 comments

Given the somewhat scary errors one can get with Formatting.jl is there a good reason not to use the standard library Printf instead?

Answer 1 · 2023-07-24T20:37:14.000Z

I think this is very concerning. PrettyTables is very widely used (e.g. by DataFrames) and this is the kind of thing that can cause papers to need to be retracted, delivered analyses to be incorrect, etc.

Answer 2 · 2023-07-25T11:54:10.000Z

Done!

@haberdashPI thanks for the report!
@ericphanson thanks for the PR that fixed it! :)

Answer 3 · 2023-07-25T20:48:11.000Z

One reason: Printf doesn't allow the %'0.2f syntax, allowing for commas as thousands separator.

So I would be supportive of moving back to Formatting.jl once their bug is fixed.

Answer 4 · 2023-07-28T12:18:18.000Z

Though it would be better if it were built in, can't this be solved with a wrapper and clever application of `replace`?

…

On Tue, Jul 25, 2023, 4:48 PM pdeffebach ***@***.***> wrote: One reason: Printf doesn't allow the %'0.2f syntax, allowing for commas as thousands separator. So I would be supportive of moving back to Formatting.jl once their bug is fixed. — Reply to this email directly, view it on GitHub <#210 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB37KWHN52MNQ23KSFTHSUDXSAWJLANCNFSM6AAAAAA2WC67AU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Answer 5 · 2023-07-29T16:10:08.000Z

@pdeffebach @haberdashPI to the extent that we want that functionality, we could probably just migrate the relevant chunk of Formatting.jl, which is actually just wrapping Printf:

https://github.com/JuliaIO/Formatting.jl/blob/e4c9f60020e965a72abae049ddac7e02bf986067/README.md?plain=1#L139-L144

Answer 6 · 2023-07-29T18:21:41.000Z

Well, maybe you would consider moving to Format.jl 😄
I'm fixing the bugs and getting PRs that have been languishing in Formatting.jl ported and merged into Format.jl

Answer 7 · 2023-07-29T20:45:58.000Z

Hi @ScottPJones !

That would be awesome! Are the bugs that started this thread fixed in Format.jl?

Answer 8 · 2023-08-01T13:08:49.000Z

@palday Here is the relevant issue (there seems to be an open PR).

Answer 9 · 2023-08-01T13:29:50.000Z

@ronisbr I've fixed one of them (at the Hackathon 😄 ) and I'm working on the issue with the "e" format right now.
I'm also going to look at the rest of the PRs submitted to Formatting.jl, as they seem to be languishing there.