Support starting local environment with a different domain (not learnpython.org)

Question

Support starting local environment with a different domain (not learnpython.org)

Closed this issue 3 years ago · 9 comments

The make command needs to be able to support the DOMAIN argument so that

DOMAIN=learnjavaonline.org make dev

would work

Answer 1 · 2021-10-25T13:21:52.000Z

Hey @ronreiter , I've been working on this issue, docker run -p 5000:5000 interactive-tutorials "-d learn-golang.org" doesn't seem to take me to golang's page, it's still going to python's page.

Can you check

Answer 2 · 2021-10-25T13:26:36.000Z

@shrn01 you need to modify the Dockerfile for this to work. Can you create a PR and fix it?

Answer 3 · 2021-10-25T13:35:43.000Z

Yeah I'll work on it

Answer 4 · 2021-10-25T14:37:03.000Z

Hey Ron, seems like the Gunicorn server doesn't allow taking arguments from the command line. If the docker setup is just for development, we could get away with using the default flask server and use ENV variables in dockerfile to call the specific server.

For production, we need to find some other permanent fix.

Answer 5 · 2021-10-25T14:40:05.000Z

@shrn01 this is for development only. dev should have an override to run flask dev server instead of gunicorn

Answer 6 · 2021-10-30T09:34:04.000Z

@shrn01 I finished this just now, please refer to the readme file

Answer 7 · 2021-10-30T12:35:18.000Z

Hey Ron, yeah I basically did this before with the dockerfile, and then scrapped it as I wasn't able to do it with Gunicorn.

So yeah this is just for dev environment, we don't need to care about production here, so no need for Gunicorn!!

Answer 8 · 2021-10-30T14:01:08.000Z

Correct. Gunicorn is only required in production, which is why the docker compose overrides the gunicorn command

Answer 9 · 2021-10-30T14:14:17.000Z

Yeah, here dockerfile and docker-compose are two different ways of running a docker container right, so i didn't get what you meant by override gunicorn before. Everything makes sense now!!