rookLab/react-component-caching

RenderToNodeStream docs don't match actual API

kylepotts opened this issue · 3 comments

renderToNodeStream

  • component: The React component being rendered
  • cache: The component cache object
  • res: The response object that Express provides
  • htmlStart: Start of html markup in string form
  • htmlEnd: End of html markup in string form
  • memLife: (Only if using Memcached) An integer representing the lifetime (in seconds) of each Memcached entry. Defaults to 0.

https://github.com/rookLab/react-component-caching/blob/master/src/server/ReactDOMNodeStreamRenderer.js#L102

Any plans to update that? I've got custom html properties I want to inject instead of what is being added now.

Hi @kylepotts, i'm not sure if the author is still active but I created a pull request to fix this

#45

Thanks for taking care of this, David. You're right that most of us haven't been active anymore - we've talked about coming back to it but other priorities have pulled us in other directions, so it's likely it won't happen anytime soon. Happy to pass the baton to whoever is up to it.

Thank you! I love the library, and you and the team did a great job already. I’m currently working on implementing this as a proof of concept within our application. If it’s a success you’ll definitely see more contributions coming from our side :) we are a team of about 20 front end developers! So I’m pretty sure we can collaborate to bring some value to this cool project.