roskenet/spring-javafx-examples

make `launchApp` public on AbstractJavaFxApplicationSupport

jangalinski opened this issue · 2 comments

jangalinski commented

I am trying to get a springboot/JavaFx application to run with kotlin.

but when I do

@SpringBootApplication
class MyApplication : AbstractJavaFxApplicationSupport()

fun main(args: Array<String>)  {
  AbstractJavaFxApplicationSupport.launchApp(MyApp::class.java, MyView::class.java, args)
}

I cannot access the launchAppmethod since it is of protected scope.

Could you change visibility to support this usecase? It's not very useful to have this one protected imho, since the original launch is public, so you are not really hiding implementation details ...

roskenet commented

Yes, you are absolutely right! Makes no real sense to narrow the scope.
Will do this.
roskenet/springboot-javafx-support#13