rosskhanas/react-qr-code

Changelog and Releases

dzienisz opened this issue · 6 comments

dzienisz commented

Hi Ross,

amazing job with the library! I use it and love it!

Have you thought about adding proper change-log file or use GitHub releases feature?

I strongly recommend using https://github.com/conventional-changelog/standard-version as this is in my opinion industry standard.

I think that would facilitate this library as more reliable and would help check what really changed without checking all commits.

I know this is additional feature and would take some time, if I would find some time and you would not do it already I would try to code this feature.

Thanks again
Kamil (Poland, Warsaw)

rosskhanas commented

Czesc Kamil, need to add it for sure. How about https://github.com/googleapis/release-please? Seems like standard-version is deprecated and they recommend using release-please.

dzienisz commented
IanVS commented

Hi I came looking for a changelog because updating from 2.0.7 to 2.0.12 made the codes look quite a bit worse. I see that this issue is closed for about a year, but I don't see any releases or a changelog. Am I just not seeing it somewhere?

Thanks!

rosskhanas commented

@IanVS can you please share your QR codes that look worse? I'm curious because code quality was actually improved.

IanVS commented

After digging in a bit more, I agree, the codes look better. I think they are just being snapshotted by chromatic differently now that there are just a couple of paths vs many individual squares. It looked blurry in the snapshots, but fine in the browser.

My point with my previous comment though was that it wound nice to have a changelog to look through to identify what changes betw versions. I was able to find the relevant PR from the list of commits though.

rosskhanas commented

@IanVS sorry, I will try to do the changelog properly.

  • ❤️1