rougeth/bottery

Catch KeyboardInterrupt on app.run() and close session and loop

Closed this issue · 6 comments

Kalaborative commented

Hi,

close session and loop

By this do you mean, restart the app.run() session? Just making sure. Thanks!

guidiego commented

@Kalaborative I think that he wants something like use .close method from asyncion.Event and aiohttp.Session. I wrote this code right now in bottery.app:

    def close(self):
        logger.debug('Closing session and loop events')
        self._session.close()
        self.loop.close()
rougeth commented

Yep, that is it @guidiego, session without _ and calling this new method on bottery.cli.run after catching KeyboardInterrupt exception.

  • 🎉1
rougeth commented

@Kalaborative just remember to test it :)

guidiego commented

@rougeth could I handle that one? Or prefer waiting a couple of days?

rougeth commented

@guidiego nooo, go ahead my friend :)