roverdotcom/django-inlinecss

Python 3 support

Opened this issue · 4 comments

On Python 3 I get this error:

  File "...python3.5/site-packages/pynliner/__init__.py", line 222, in _get_external_styles
    self.style_string += self._get_url(url)
TypeError: Can't convert 'bytes' object to str implicitly

It's a pynliner problem.
I have already described it here and opened a pull request to fix this but @rennat seem to be too busy to review it.

Is there a way to make django-inlinecss work with Python 3?

The pull request has been merged and released to pypi. Please release a new version that depends on pynliner instead of pynliner3.

@utapyngo how did u solve it?

Switched to django-mailcss.

Seems that this can be closed, Python 3 has worked now for a long while.