Checkmark image is not visible on selected items

Question

Checkmark image is not visible on selected items

Closed this issue 4 years ago · 9 comments

Checkmark images are not visible on selected items. I just run the GMPhotoPicker.Xamarin project without any changes. Please see the screenshot for details.

Answer 1 · 2019-10-31T08:15:23.000Z

I found that following change (adding _selectedButton to _coverView) fixes this problem.

//GMGridViewCell.cs
public void Initialize ()
{
...
_selectedButton.SetImage (null, UIControlState.Normal);
_selectedButton.SetImage (UIImage.FromFile ("GMSelected"), UIControlState.Selected);
_coverView.AddSubview(_selectedButton);
...

Answer 2 · 2019-10-31T09:43:34.000Z

Hi, cool, would you like to make a PR for it?

Answer 3 · 2019-11-12T13:09:01.000Z

Hi Roy, could you please check the PR?

Answer 4 · 2019-12-24T09:16:53.000Z

@sergbuk I'm facing same issue, have you got any solution?

Answer 5 · 2019-12-24T09:20:20.000Z

I found that following change (adding _selectedButton to _coverView) fixes this problem.

//GMGridViewCell.cs
public void Initialize ()
{
...
_selectedButton.SetImage (null, UIControlState.Normal);
_selectedButton.SetImage (UIImage.FromFile ("GMSelected"), UIControlState.Selected);
_coverView.AddSubview(_selectedButton);
...

exactly where this change needs to be add ?

Answer 6 · 2020-01-07T07:28:50.000Z

@divyesh008
add following line:
_coverView.AddSubview(_selectedButton);
after this one:
_selectedButton.SetImage (UIImage.FromFile ("GMSelected"), UIControlState.Selected);

Answer 7 · 2020-09-23T06:06:57.000Z

The PR for this has been merged. Closing the issue.

Answer 8 · 2021-01-22T20:01:36.000Z

Hi, I know this issue is closed since Sep 23 but I'm facing with it, image selected checkmark isn't visible.

I'm creating the picker this way:
`
var picker = new GMImagePickerController
{
Title = "Select Photo",
CustomDoneButtonTitle = "Finished",
CustomCancelButtonTitle = "Cancel",
ColsInPortrait = 4,
ColsInLandscape = 7,

            DisplaySelectionInfoToolbar = true,
            AllowsMultipleSelection = true,
            ShowCameraButton = true,
            AutoSelectCameraImages = true,
            
            ModalPresentationStyle = UIModalPresentationStyle.FullScreen,
            MediaTypes = new[] { PHAssetMediaType.Image },
           `

@roycornelissen @sergbuk, Can you help me?

Thank you!

Answer 9 · 2021-10-05T18:35:57.000Z

This is still an issue.
I'm using NuGet "GMImagePicker.Xamarin" version 2.5.1 in a VS2019 (16.11.3) Xamarin.iOS (14.20.0.25) project running on an iPhone 8 iOS 13.7 Simulator on a Mac Mini M1 with Xcode 12.5.

Selected images receive a blue-ish overlay, but no check box.

FWIW: I can't use any newer Xcode (e.g. 13) or simulator (e.g. iOS 14/15) because of various incompatibilities with Xamarin hot reload and broken ImagePicker running in a simulator on M1 silicon)