insufficient semantic test (Maybe in SymbolType.isCompatible?)
Closed this issue · 3 comments
cal101 commented
I don't think the real problem of SymbolType.isCompatible was solved with
the solution to #30.
For generic cases the method is skipping most of it's code.
See #32
If the style of the test change is OK for you (I didn't want to duplicate too much code) I can change more test cases to positive/negative cases.
Or do I completely miss something?
cal101 commented
As discussed in #30 the new test case is wrong because it won't compile.
What I missed is that only compilable code is checked.
So my change should be reverted. I take a look later if I find missing compilable cases.
Thanks for looking into it and sorry for the confusion.
cal101 commented
Issue is cared for in more specific other tickets.